Review of "TouchFisher" version 1

Details Page Preview

一只陪你上班、按实际工作时间计算今日收入的小摸鱼。


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:232
            this._amountLabel = new St.Label({
                text: `${currency}${snapshot.day.earned.toFixed(2)}`,
                style_class: 'touchfisher-earned',
            })
  • extension.js:43
            this._button = new St.BoxLayout({
                style_class: 'touchfisher-button',
                vertical: false,
            })
  • extension.js:52
            this._buttonAmountLabel = new St.Label({
                text: '',
                style_class: 'touchfisher-button-amount',
                y_align: Clutter.ActorAlign.CENTER,
                visible: false,
            })
  • extension.js:48
            this._fishLabel = new St.Label({
                text: '🐟',
                y_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:249
            this._monthLabel = new St.Label({
                text: `本月已赚  ${currency}${snapshot.month.earned.toFixed(2)}`,
                style_class: 'touchfisher-period',
            })
  • extension.js:236
            this._progressLabel = new St.Label({
                text: this._formatProgress(snapshot.day.progress),
                style_class: 'touchfisher-progress',
            })
  • extension.js:240
            this._statusLabel = new St.Label({
                text: this._formatStatus(snapshot.status),
                style_class: 'touchfisher-status',
            })
  • extension.js:245
            this._weekLabel = new St.Label({
                text: `本周已赚  ${currency}${snapshot.week.earned.toFixed(2)}`,
                style_class: 'touchfisher-period',
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:52
            this._buttonAmountLabel = new St.Label({
                text: '',
                style_class: 'touchfisher-button-amount',
                y_align: Clutter.ActorAlign.CENTER,
                visible: false,
            })
  • extension.js:48
            this._fishLabel = new St.Label({
                text: '🐟',
                y_align: Clutter.ActorAlign.CENTER,
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:61
            this._indicator.connect('notify::hover', () => {
                if (this._buttonAmountLabel)
                    this._buttonAmountLabel.visible = this._indicator.hover;
            })
  • extension.js:74
            this._menu.connect('open-state-changed', (_menu, isOpen) => {
                if (isOpen)
                    this._rebuildMenu();
            })

All Versions

Version Status
1 Unreviewed