Review of "LensGuard" version 1.4.0 (2)

Details Page Preview

Shows apps using your camera via V4L2. Requires lensguard-service.

Extension Homepage
https://github.com/YounesRabeh/lensguard

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
1.8.0 (3) Unreviewed
1.4.0 (2) Rejected
1.3.0 (1) Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Where is the git URL? Is this code generated by AI? If so, we have a rule for that: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated)
Younes posted a review
HI @JustPerfection, sorry this is my first time submitting, here's the url: https://github.com/YounesRabeh/lensguard And yes i used a cli agent to TDD the project, especially for the dbus module. The files under /extension are mostly rewritten legacy code from an old repo. I tried making something similar before, but it never worked consistently. To be frank, now that I've read the GJS more thoroughly, I see that the repo has some much needed changes... licence among many other stuff, I won't steal any more of your time, but will you consider the project a lost cause due to the heavy ai driven pipeline, and is it better to keep it a private side project ? This version is barely out of beta, the main features are still to come, so do you suggest to keep wonking on it or starting fresh, maybe with a new idea. thanks in advance
JustPerfection rejected
1. Please add GitHub or GitLab repo url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. Remove line 15-16 `extension.js`. Not needed. 3. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup (`extension.js` process only). 4. Better to remove the png files and use svg file since they are scalable. 5. Remove line 132-133 `src/dbusClient.js` since that falls under selective disable. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions