Review of "Notes" version 1

Details Page Preview

Simple notes for the GNOME Shell desktop.

Extension Homepage
https://github.com/pelach/notes-extension-gnome

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • noteBox.js:588
    file.load_contents(null)
  • noteBox.js:638
    file.load_contents(null)

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:60
    this.panel_button = new PanelMenu.Button(0.0, _("Show notes"), false)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:66
            this.panel_button.connect(
                'button-press-event',
                this._onButtonPressed.bind(this)
            )

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:12
    this._settings = this.getSettings()

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

pch76 auto- rejected
Auto-rejected because of new version 2 was uploaded