Review of "Tasks Tracker" version 1

Details Page Preview

A simple panel button to add, track, and remove tasks.

Extension Homepage
https://github.com/haris-a11/tasks-tracker-haris11.local

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:161
    file.load_contents(null)

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:296
        this._settings = this.getSettings(
          "org.gnome.shell.extensions.tasks-tracker",
        )

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

eleven11 posted a review
I'll reupload again after fixing shexli issues. I am unable to run shexli locally so i uploaded here to figure the issues
JustPerfection rejected
Ok but please fix all of them: 1. Don't need to use any parameters for `this.getSettings()` since you already have that in `metadata.json`. 2. Please use aysnc for reading file content since you are in shell process (line 161 `extension.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) 3. Please use a less generic name for the default class you are exporting (line 294 `extension.js`). 4. Also null out in disable: ```js this._settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 5. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup (`extension.js` process only). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions