Review of "Always On Display" version 4

Details Page Preview

Shows clock, date and notifications on a black background instead of turning off the display on the lock screen

Extension Homepage
https://github.com/artokarin/gnome-extenstion-always-on-lockscreen

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:696
        disable() {
            // GNOME calls disable() on the switch to the lock screen, where AOD
            // must keep running — clean up only once the session leaves it.
            if (!Main.sessionMode.isLocked && this._aod) {
                this._aod.disable();
                this._aod = null;
            }
        }

All Versions

Version Status
5 Rejected
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

nightwing666 auto- rejected
Auto-rejected because of new version 5 was uploaded