Review of "Angry Mouse" version 1

Details Page Preview

Reveal the active pointer with a large animated cursor, or draw a fading laser trail while dragging.

Extension Homepage
https://github.com/Jamir-boop/angry-mouse-gnome

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:39
            this._actor.connect('destroy', () => {
                this._actor = null;
                this._contentReady = false;
            })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:249
            this._doubleHoldTimeoutId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 10, () => {
                this._doubleHoldTimeoutId = 0;
                this._keyboardHeld = this._doubleControl.confirmHold(
                    GLib.get_monotonic_time() / 1000);
                this._updateActive();
                return
  • extension.js:121
                this._shakeTimeoutId = GLib.timeout_add(
                    GLib.PRIORITY_DEFAULT,
                    this._settings.get_int('visible-duration-ms'),
                    () => {
                        this._shakeTimeoutId = 0;
                        this._shakeHeld = false;
                        this._upda

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:10
    this._settings = this.getSettings()
  • prefs.js:113
    this._shortcutLabel = new Gtk.ShortcutLabel({valign: Gtk.Align.CENTER})
  • prefs.js:134
    this._recordingModifiers = new Set()

All Versions

Version Status
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

jamir-boop auto- rejected
Auto-rejected because of new version 2 was uploaded