Review of "Internet Speed Meter" version 5

Details Page Preview

A lightweight, real-time network speed monitor for your GNOME Shell top panel. Displays upload and download speeds with minimal CPU overhead.

Extension Homepage
https://github.com/foss-desk/internet-speed-meter

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:90
            this._box = new St.BoxLayout({
                style_class: 'speed-meter-box',
                vertical: false,
                y_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:95
            this._downLabel = new St.Label({
                text: '',
                style_class: 'speed-meter-label',
                y_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:100
            this._sepLabel = new St.Label({
                text: '\u2502',
                style_class: 'speed-meter-label speed-meter-sep-label',
                y_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:459
    this._speedTestDownVal = new St.Label({ text: '--', style_class: 'speed-meter-ookla-gauge-value speed-meter-down-value' })
  • extension.js:474
    this._speedTestQualityVal = new St.Label({ text: 'Press GO to start speed test', style_class: 'speed-meter-ookla-status-text' })
  • extension.js:481
    this._speedTestRunBtnLabel = new St.Label({ text: 'GO', style_class: 'speed-meter-ookla-go-label' })
  • extension.js:466
    this._speedTestUpVal = new St.Label({ text: '--', style_class: 'speed-meter-ookla-gauge-value speed-meter-up-value' })
  • extension.js:105
            this._upLabel = new St.Label({
                text: '',
                style_class: 'speed-meter-label',
                y_align: Clutter.ActorAlign.CENTER,
            })

All Versions

Version Status
6 Rejected
5 Rejected
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
You should use Soup instead line 545 `extension.js`: https://gjs.guide/extensions/upgrading/gnome-shell-43.html#soup3