Review of "Ringlight" version 6

Details Page Preview

Puts a soft, warm glow around the edges of your screen so your face is lit during video calls. Turns itself on whenever an app opens the webcam. Brightness, colour and size are in the panel menu and the extension settings.

Extension Homepage
https://github.com/twigglits/ringlight

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:37
            this._auto = new PopupMenu.PopupSwitchMenuItem(
                'Follow camera', settings.get_boolean('auto-mode'))
  • extension.js:32
            this._onOff = new PopupMenu.PopupSwitchMenuItem(
                'Ring Light', settings.get_boolean('enabled'))

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:37
            this._auto = new PopupMenu.PopupSwitchMenuItem(
                'Follow camera', settings.get_boolean('auto-mode'))
  • extension.js:32
            this._onOff = new PopupMenu.PopupSwitchMenuItem(
                'Ring Light', settings.get_boolean('enabled'))

All Versions

Version Status
8 Active
7 Rejected
6 Rejected
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

twigglits auto- rejected
Auto-rejected because of new version 7 was uploaded