Review of "Clipboard Khipu" version 0.1.0 (3)

Details Page Preview

Developer-focused clipboard history for GNOME Shell. Press Super+V to see what you've copied — text, images and files — and paste it back exactly as it was.

Extension Homepage
https://github.com/RuddyQuispe/clipboard-khipu

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3 manual_review 1

Shexli found 4 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • clipboardMonitor.js:59
    St.Clipboard.get_default()
  • paster.js:80
    St.Clipboard.get_default()
  • paster.js:121
    St.Clipboard.get_default()
  • paster.js:180
    St.Clipboard.get_default()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • historyView.js:73
    this._backdrop = new St.Widget({ reactive: true })
  • historyView.js:58
            this._container = new St.BoxLayout({
                vertical: true,
                style_class: 'khipu-popup',
                width: POPUP_WIDTH,
                reactive: true,
            })
  • historyView.js:50
    this._listBox = new St.BoxLayout({ vertical: true, style_class: 'khipu-list', x_expand: true })
  • historyView.js:51
            this._scrollView = new St.ScrollView({
                style_class: 'khipu-scroll',
                hscrollbar_policy: St.PolicyType.NEVER,
                vscrollbar_policy: St.PolicyType.AUTOMATIC,
                x_expand: true,
            })
  • historyView.js:42
            this._searchEntry = new St.Entry({
                style_class: 'khipu-search',
                hint_text: 'Type to filter…',
                can_focus: true,
                x_expand: true,
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • historyView.js:73
    this._backdrop = new St.Widget({ reactive: true })
  • historyView.js:58
            this._container = new St.BoxLayout({
                vertical: true,
                style_class: 'khipu-popup',
                width: POPUP_WIDTH,
                reactive: true,
            })
  • historyView.js:50
    this._listBox = new St.BoxLayout({ vertical: true, style_class: 'khipu-list', x_expand: true })
  • historyView.js:51
            this._scrollView = new St.ScrollView({
                style_class: 'khipu-scroll',
                hscrollbar_policy: St.PolicyType.NEVER,
                vscrollbar_policy: St.PolicyType.AUTOMATIC,
                x_expand: true,
            })
  • historyView.js:42
            this._searchEntry = new St.Entry({
                style_class: 'khipu-search',
                hint_text: 'Type to filter…',
                can_focus: true,
                x_expand: true,
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • historyView.js:75
            this._backdrop.connect('button-press-event', () => {
                this._close();
                return Clutter.EVENT_STOP;
            })
  • historyView.js:71
    this._container.connect('button-press-event', () => Clutter.EVENT_STOP)
  • historyView.js:48
    this._searchEntry.clutter_text.connect('key-press-event', (_actor, event) => this._onKeyPress(event))
  • historyView.js:49
    this._searchEntry.clutter_text.connect('text-changed', () => this._onSearchChanged())

All Versions

Version Status
0.1.0 (3) Unreviewed
0.1.0 (2) Rejected
0.1.0 (1) Rejected

Previous Reviews on this Version

rquispe posted a review
upgrade and fix code files about warning of EGO
rquispe posted a review