Review "System Tray Monitor" version 1

Review of "System Tray Monitor" version 1

Details Page Preview

System Tray Monitor

Shows CPU, memory, temperature, network and disk activity in the top bar. Every metric can be turned on or off and rendered in one of nine presets, or a custom combination of its own.

Extension Homepage: https://github.com/JamieDF/system-tray-monitor

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

src/metrics/procfs.js:37
```
GLib.file_get_contents(path)
```

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

.gitignore
```
.gitignore
```
docs/screenshots/preferences.png
```
docs/screenshots/preferences.png
```
docs/screenshots/panel.png
```
docs/screenshots/panel.png
```

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

tests/cpu.test.js
tests/detail.test.js
tests/disk.test.js
tests/draw.test.js
tests/harness.js
tests/history.test.js
tests/icons.test.js
tests/memory.test.js
tests/network.test.js
tests/poller.test.js
tests/presets.test.js
tests/procfs.test.js
tests/rates.test.js
tests/run.js
tests/stylesheet.test.js
tests/thermal.test.js
tests/units.test.js
tests/width.test.js

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

extension.js:192

this._settings.connect(
            'changed', (_settings, key) => this._onSettingChanged(key))

All Versions

Version	Status
1	Unreviewed