Review of "Matrix Code Rain" version 1

Details Page Preview

Matrix animated green code rain behind your windows on every workspace and monitor. Requires a GPU to run.

Extension Homepage
https://github.com/cwittenberg/matrix-rain

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • prefs.js:43
            console.log(`[matrix-rain] ${JSON.stringify({
                event: 'prefs-setting-written',
                key,
                value,
                written,
            })}`)
  • prefs.js:51
        console.log(`[matrix-rain] ${JSON.stringify({
            event: 'prefs-switch-ready',
            key,
            value: settings.get_boolean(key),
        })}`)
  • prefs.js:93
            console.log(`[matrix-rain] ${JSON.stringify({
                event: 'prefs-setting-written',
                key: options.key,
                value,
                written,
            })}`)
  • prefs.js:102
        console.log(`[matrix-rain] ${JSON.stringify({
            event: 'prefs-scale-ready',
            key: options.key,
            value: settings.get_double(options.key),
            widget: 'Gtk.Scale',
        })}`)
  • prefs.js:241
    console.log('[matrix-rain] {"event":"prefs-start"}')
  • prefs.js:246
    console.log('[matrix-rain] {"event":"prefs-complete"}')

All Versions

Version Status
5 Active
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `.v5` from schema id. 2. Remove emojis from prefs: https://gjs.guide/extensions/review-guidelines/best-practices.html#ui-elements-icons-vs-emojis 3. Use `connectObject()` and `disconnectObject()`.