Review of "Desktop in Switcher" version 4

Details Page Preview

Adds a Desktop entry to GNOME's application and window switchers.

Extension Homepage
https://github.com/teskilatsiz/desktop-in-switcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • install.sh
    install.sh
  • po/ru.po
    po/ru.po
  • po/desktop-in-switcher@teskilatsiz.pot
    po/desktop-in-switcher@teskilatsiz.pot
  • po/it.po
    po/it.po
  • po/de.po
    po/de.po
  • po/pt.po
    po/pt.po
  • po/fr.po
    po/fr.po
  • po/es.po
    po/es.po
  • po/LINGUAS
    po/LINGUAS
  • po/tr.po
    po/tr.po

All Versions

Version Status
6 Active
5 Active
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. What's the reason for `!== 'function'`? 2. Remove files and folders: - `assets` -`po` - `install.sh` -`uninstall.sh` - `update-translations.sh`
Teşkilatsız posted a review
Thanks for the review. You're right about the `!== 'function'` checks. I added them as an overly defensive compatibility guard, but they are not needed for the GNOME Shell versions listed in metadata.json. I removed them and simplified the code. I also rebuilt the package so it only includes the files needed by the extension, plus the compiled locale files. The new ZIP passes shexli with 0 findings.