Review of "Blackstrat Desktop Icons" version 3

Details Page Preview

Free-placement desktop icons with context menu. This extension accesses the system clipboard to support cut, copy, and paste of files between the desktop and other applications. Known limitation: cut/paste and drag&drop of files between the desktop and Nautilus (Files) are not fully supported yet.

Extension Homepage
https://github.com/BlackStrat4/blackstrat-desktopicons

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:931
    St.Clipboard.get_default()
  • extension.js:1003
    St.Clipboard.get_default()
  • extension.js:1946
    St.Clipboard.get_default()
  • extension.js:1953
    St.Clipboard.get_default()
  • extension.js:1960
    St.Clipboard.get_default()
  • extension.js:1986
    St.Clipboard.get_default()
  • extension.js:1992
    St.Clipboard.get_default()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:61
    this.menuManager = new PopupMenu.PopupMenuManager(Main.layoutManager.dummyCursor || Main.uiGroup)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:1911
            clutterText.connect('activate', () => {
                applyRename();
            })
  • extension.js:1914
            clutterText.connect('key-press-event', (actor, event) => {
                let key = event.get_key_symbol();
                let state = event.get_state();
                let ctrl = (state & Clutter.ModifierType.CONTROL_MASK) !== 0;
    
                if (key === Clutter.KEY_Escape) {
                    committ

All Versions

Version Status
6 Unreviewed
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Dimitris auto- rejected
Auto-rejected because of new version 4 was uploaded