Review of "Distrobox Launcher" version 1

Details Page Preview

Quick access to your distroboxes from the top bar. Enter, start, and stop distroboxes with one click. Container names can be copied to the clipboard via an explicit menu action.

Extension Homepage
https://github.com/thiagormoreira/distrobox-launcher

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:205
    St.Clipboard.get_default()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:197
                GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, 2, () => {
                    this._refreshContainers();
                    return GLib.SOURCE_REMOVE;
                })
  • extension.js:275
                GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, 1, () => {
                    this._refreshContainers();
                    return GLib.SOURCE_REMOVE;
                })
  • extension.js:285
                GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, 2, () => {
                    this._refreshContainers();
                    return GLib.SOURCE_REMOVE;
                })
  • extension.js:350
                GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, 2, () => {
                    this._refreshContainers();
                    return GLib.SOURCE_REMOVE;
                })

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Where is the git URL? Is this code generated by AI? If so, we have a rule for that: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated)
LoganGuns auto- rejected
Auto-rejected because of new version 2 was uploaded