Review of "Rclone Mounter" version 1

Details Page Preview

Mount configured rclone configs into your filesystem

Extension Homepage
https://github.com/arjan/gnome-shell-rclone-mounter

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • lib/rclone.js:31
    GLib.file_get_contents(path)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • shell/indicator.js:65
            this._ejectButton.connect('clicked', () => {
                if (!this._busy)
                    this.emit('unmount');
            })

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:23
    this._mountsGroup = this._createMountsGroup(window, settings)

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Where is the git URL? Is this code generated by AI? If so, we have a rule for that: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated)
arjan posted a review
Yes, this code is generated by AI. However I take full resposibility for maintenance, I am a developer and gnome user for over 20 years. This is not my first extension. Actually, the best-practices document is in the source tree, the AI read it. https://github.com/arjan/gnome-shell-rclone-mounter
JustPerfection rejected
1. Please add GitHub or GitLab repo url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. Please use aysnc for reading file content since you are in shell process (line 31 `lib/rclone.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions