EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

• extension.js:2317

  this.equalizer = new EqualizerIcon()

• extension.js:2318

  this.stack = new CardStack(closeMenu, keepStackVisible)

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

• extension.js:2317

  this.equalizer = new EqualizerIcon()

• extension.js:2318

  this.stack = new CardStack(closeMenu, keepStackVisible)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:333

  this._timeline.connect('new-frame', () => this._onFrame())

• extension.js:596

  this._timeline.connect('new-frame', () => this._onFrame())

• extension.js:787

  this._badge.connect('notify::width', () => this._placeBadge())

• extension.js:786

  this._coverTile.connect('notify::height', () => this._placeBadge())

• extension.js:785

  this._coverTile.connect('notify::width', () => this._placeBadge())

• extension.js:2515

          this.menu.connect('open-state-changed', (_menu, open) => {
              if (open)
                  this._model.stack.onMenuOpened();
          })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

• extension.js:1227

          this._artRetryId = GLib.timeout_add(GLib.PRIORITY_DEFAULT,
              ART_RETRY_INTERVAL, () => {
                  this._artRetryTries++;
                  const artwork = this._artworkIcon(coverUrl);
  
                  // A picture that arrived is worth showing even before it can
                

• extension.js:1521

          this._pollId = GLib.timeout_add(GLib.PRIORITY_LOW, delayMs, () => {
              this._pollId = null;
              this._fetchPosition();
              this._updatePoll();
              return GLib.SOURCE_REMOVE;
          })

• extension.js:1455

          this._seekPendingId = GLib.timeout_add(GLib.PRIORITY_DEFAULT,
              SEEK_COALESCE_MS, () => {
                  this._seekPendingId = null;
                  this._seekToSlider();
                  return GLib.SOURCE_REMOVE;
              })

• extension.js:1150

          this._volumePendingId = GLib.timeout_add(GLib.PRIORITY_DEFAULT,
              VOLUME_COALESCE_MS, () => {
                  this._volumePendingId = null;
                  this._pushVolume();
                  return GLib.SOURCE_REMOVE;
              })

• extension.js:2003

          this._retryId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, PROPERTY_RETRY_MS,
              () => {
                  this._retryId = null;
                  missing.forEach(([proxy, iface]) => this._fetchProperties(proxy, iface));
                  return GLib.SOURCE_REMOVE;
              })