Review of "Mpris Player Control" version 1.0.0 (1)

Details Page Preview

Panel indicator for controlling media players that support the MPRIS interface.

Extension Homepage
https://github.com/pic16f877ccs/Mpris-player-control

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:278
            this._backwardButton = new St.Icon({
                icon_name: 'media-skip-backward-symbolic',
                style_class: 'control-panel-icon system-status-icon',
            })
  • extension.js:261
            this._controlBox = new St.BoxLayout({
                orientation: Clutter.Orientation.HORIZONTAL,
                x_expand: true,
                y_expand: true,
            })
  • extension.js:270
            this._forwardButton = new St.Icon({
                icon_name: 'media-skip-forward-symbolic',
                style_class: 'control-panel-icon system-status-icon',
            })
  • extension.js:251
            this._indicatorBox = new St.BoxLayout({
                orientation: Clutter.Orientation.HORIZONTAL,
                x_expand: true,
                y_expand: true,
                style_class: 'panel-button',
            })
  • extension.js:294
            this._pauseButton = new St.Icon({
                icon_name: 'media-playback-pause-symbolic',
                style_class: 'control-panel-icon system-status-icon',
            })
  • extension.js:286
            this._playButton = new St.Icon({
                icon_name: 'media-playback-start-symbolic',
                style_class: 'control-panel-icon system-status-icon',
            })
  • extension.js:310
            this._playerIcon = new St.Icon({
                fallback_icon_name: 'audio-x-generic-symbolic',
                style_class: 'player-icon system-status-icon',
            })
  • extension.js:302
            this._stopButton = new St.Icon({
                icon_name: 'media-playback-stop-symbolic',
                style_class: 'control-panel-icon system-status-icon',
            })
  • extension.js:325
            this._trackLabel = new St.Label({
                style_class: 'player-title',
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:278
            this._backwardButton = new St.Icon({
                icon_name: 'media-skip-backward-symbolic',
                style_class: 'control-panel-icon system-status-icon',
            })
  • extension.js:261
            this._controlBox = new St.BoxLayout({
                orientation: Clutter.Orientation.HORIZONTAL,
                x_expand: true,
                y_expand: true,
            })
  • extension.js:270
            this._forwardButton = new St.Icon({
                icon_name: 'media-skip-forward-symbolic',
                style_class: 'control-panel-icon system-status-icon',
            })
  • extension.js:251
            this._indicatorBox = new St.BoxLayout({
                orientation: Clutter.Orientation.HORIZONTAL,
                x_expand: true,
                y_expand: true,
                style_class: 'panel-button',
            })
  • extension.js:294
            this._pauseButton = new St.Icon({
                icon_name: 'media-playback-pause-symbolic',
                style_class: 'control-panel-icon system-status-icon',
            })
  • extension.js:286
            this._playButton = new St.Icon({
                icon_name: 'media-playback-start-symbolic',
                style_class: 'control-panel-icon system-status-icon',
            })
  • extension.js:310
            this._playerIcon = new St.Icon({
                fallback_icon_name: 'audio-x-generic-symbolic',
                style_class: 'player-icon system-status-icon',
            })
  • extension.js:302
            this._stopButton = new St.Icon({
                icon_name: 'media-playback-stop-symbolic',
                style_class: 'control-panel-icon system-status-icon',
            })
  • extension.js:325
            this._trackLabel = new St.Label({
                style_class: 'player-title',
            })

All Versions

Version Status
1.0.0 (1) Unreviewed