Review of "Focus Tasks" version 2

Details Page Preview

Start a focus timer from a Google Tasks task.

Extension Homepage
https://github.com/hassanaziz0012/focus

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • lib/sessionLogger.js:39
    file.load_contents(null)
  • lib/utils.js:92
    Gio.File.new_for_path(CONFIG_PATH).load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:50
            this.menu.connect('open-state-changed', (_menu, isOpen) => {
                if (isOpen && this._tasks.length === 0 && !this._isLoadingTasks) {
                    fetchTasks(this);
                }
            })

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove version from the import: - line 5 `extension.js` - line 3 `lib/googleTasks.js` - line 5 `prefs.js` 2. Remove line 7 `lib/utils.js` 3. Please use aysnc for reading file content since you are in shell process: - line 92 `lib/utils.js` - line 39 `lib/sessionLogger.js` [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async)