EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

• .gitignore

  .gitignore

• po/update-pot.sh

  po/update-pot.sh

• po/aqua-dock-pro.pot

  po/aqua-dock-pro.pot

• po/README.md

  po/README.md

• po/POTFILES.in

  po/POTFILES.in

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

• schemas/gschemas.compiled

  schemas/gschemas.compiled

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

• tests/animationEngine.test.js
• tests/customItems.test.js
• tests/fanGeometry.test.js
• tests/fileClipboard.test.js
• tests/fileEnumerator.test.js
• tests/fileService.test.js
• tests/fullscreenPolicy.test.js
• tests/iconResolution.test.js
• tests/layout.test.js
• tests/layoutStructures.test.js
• tests/locationResolver.test.js
• tests/mountedDevices.test.js
• tests/prefsSmoke.test.js
• tests/previewPaging.test.js
• tests/settings.test.js
• tests/settingsMigration.test.js
• tests/springSolver.test.js
• tests/windowFilter.test.js

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• services/appTracker.js:29

  this._baseSignals.connect(this._favorites, 'changed', () => this._emitAll())

• services/appTracker.js:30

          this._baseSignals.connect(this._appSystem, 'installed-changed', () => {
              // Desktop-file updates are the point at which an application's icon
              // identity can legitimately change. Share stable icons across docks
              // between those events instead of asking Shel

• services/appTracker.js:38

  this._baseSignals.connect(this._appSystem, 'app-state-changed', () => this._emitAll())