EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• lib/authorization.js:128

  GLib.file_get_contents('/proc/self/stat')

• lib/details.js:51

  Gio.File.new_for_path('/etc/fstab').load_contents(null)

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

• lib/icon.js:20

  Extension.lookupByURL(import.meta.url)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:419

              this._clickGesture?.connect('recognize', gesture =>
                  this._clicked(gesture.get_button?.() ?? Clutter.BUTTON_PRIMARY))

• extension.js:442

          this.menu.connect('open-state-changed', (_menu, open) => {
              if (open) {
                  this._rebuild();
              } else {
                  this._shown.clear();
                  this._lock.relock();
              }
          })

• extension.js:640

              row.connect('key-focus-in', () => {
                  if (row.hover)
                      return;
                  ensureActorVisibleInScrollView(scroll, row);
              })

• lib/compare.js:157

  actor.connect('key-focus-in', reveal)

• lib/compare.js:158

  actor.connect('key-focus-out', reveal)

• lib/dialog.js:160

  this._aside.connect('destroy', () => (this._aside = null))

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

• extension.js:167

          this._freshId = GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT,
              Math.ceil(FRESH - age), () => {
                  this._freshId = 0;
                  this.remove_style_class_name('wisp-fresh');
                  return GLib.SOURCE_REMOVE;
              })

• lib/dialog.js:215

          this._pending = GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
              this._pending = 0;
              this._measure();
              return GLib.SOURCE_REMOVE;
          })

• lib/dialog.js:162

              this._ticking = GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, 1,
                  () => {
                      this._say();
                      return GLib.SOURCE_CONTINUE;
                  })