Review of "Focus Tracker" version 1

Details Page Preview

A simple panel button to track focused sessions against a task. Completed sessions are stored locally in a JSON file under your user data directory. Nothing is sent anywhere.

Extension Homepage
https://github.com/haris-a11/focus-tracker

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

eleven11 posted a review
Resubmission of Focus Tracker, previously submitted as focus-tracker@haris11.local. What changed since that submission: The UUID is now focus-tracker@haris-a11.github.io. The previous .local namespace was not a domain I control. Removed module scoped session store. The panel button's GLib timeout source is removed in destroy(), by the function _stopTicking(). prefs.js cancels its asynchronous read of sessions.json with a Gio.Cancellable when the window is destroyed, and removes the idle source it adds on Sessions are appended to ~/.local/share/focus-tracker/sessions.json.
JustPerfection rejected
Please remove line 50, 61, 164 `prefs.js` and only do it in one places. And the signal is `close-request` not `destroy`.