Review of "Hyperliquid Price Bar" version 3

Details Page Preview

Display real-time Hyperliquid cryptocurrency prices in the GNOME top panel. Features: * Top 3 tickers visible directly in the panel * Click to expand and see all tickers with price charts * Real-time WebSocket updates * Shows price, 24h change percentage, funding rates * Customizable tickers via preferences

Extension Homepage
https://github.com/zengdard/hyperbare

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • config.js:15
    GLib.file_get_contents(CONFIG_PATH)

EGO-L-007 warning

main loop sources should be removed before being recreated

Main loop sources should be removed before creating a new source on the same field.

Remove main loop sources

  • extension.js:137
            this._initIdleId = GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
                this._initIdleId = null
                this._fetchMetadataAndInit(() => {
                    this._reinitializing = false
                })
                return GLib.SOURCE_REMOVE
            })

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:9
    this._config = loadConfig()
  • prefs.js:27
    this._tickerRowsBox = new Gtk.Box({ orientation: Gtk.Orientation.VERTICAL, spacing: 6 })

All Versions

Version Status
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `settings` from `metadata.json`: [EGO Review Guidelines: unnecessary metadata keys](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. Please fix the issues mentioned in the shexli.