Review of "Haguichi Indicator" version 37

Details Page Preview

Lets you control Haguichi directly from the system status area in GNOME Shell.

Extension Homepage
https://github.com/ztefn/gse-haguichi-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:201
    this._indicator.connect('scroll-event', this._onScrollEvent.bind(this))
  • extension.js:121
            this._toggle.connect('clicked', () => {
                if (this._toggle.toggle_mode) {
                    this._toggle.checked ? this.haguichiProxy.StartHamachiRemote() : this.haguichiProxy.StopHamachiRemote()
                }
            })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Previous Reviews on this Version

JustPerfection active