Review of "Peekhassio" version 3

Details Page Preview

Peek at Home Assistant entity states from the GNOME top bar.

Extension Homepage
https://github.com/franciscogouveia/peekhassio

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

Francisco posted a review
Thank you for taking the time to review the extension. I'm linking the commit for the specific changes, if it helps to see them in isolation. In "version 3", I tackled the 2 points raised in the "version 2" feedback (both in `instances/soup-websocket-transport.js`): 1. Removed version from the import - https://github.com/franciscogouveia/peekhassio/commit/d3fa1d88991dbd87a9c4f550cb38259116d4379c 2. Timeouts are now thoroughly removed on destroy and disable. Additionally, new timeouts are prevented if scheduler is already destroyed. Extension.disable() calls the Scheduler.destroy() (see `extension.js`) - https://github.com/franciscogouveia/peekhassio/commit/94b8d224dcda713aed92ec3a439eaf06ac576abd You will also notice that it includes few unrelated changes that I worked on while waiting for the review of version 2 - sorry for that extra noise. The changes were around improving the typings for the messages received from Home Assistant (extension is written in Typescript), as well as improving the parsing of those same messages: - https://github.com/franciscogouveia/peekhassio/commit/a81ab91798966d1ba95a0ec485b22b2fc78d19ec - https://github.com/franciscogouveia/peekhassio/commit/3f8f0e9f35f260b7b9174bb61a5fd223490438f9 - https://github.com/franciscogouveia/peekhassio/commit/d8f6b6a46ad1e559461dfddc90462cb4e9460291