Review of "Big Shot" version 3

Details Page Preview

Extends GNOME's native Print Screen interface — no separate editor window. • 16 annotation tools: pen, arrows, shapes, text, highlighter, censor, blur, invert, magnify callouts, numbered badges • OCR with automatic language detection, copies text to the clipboard • Full-screen, area, and window screencasts • Desktop audio and microphone capture, independently or mixed • Hardware encoding on NVIDIA, AMD, and Intel, with software fallback • Draggable webcam overlay with 8 masks and 5 sizes • Live annotation while recording, plus pause/resume with lossless merge Clipboard access: when you press the copy button, the screenshot (PNG) or the extracted OCR text is placed on the clipboard. The extension never reads the clipboard, never sends data to a third party, and ships no default keyboard shortcut that touches clipboard data. Optional: tesseract (OCR), ffmpeg (pause/resume), gst-plugins-ugly (x264).

Extension Homepage
https://github.com/big-comm/gnome-shell-big-shot

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:1203
    St.Clipboard.get_default()
  • extension.js:1707
    St.Clipboard.get_default()
  • extension.js:1724
    St.Clipboard.get_default()
  • extension.js:1760
    St.Clipboard.get_default()

EGO-P-003 error

GSettings schema XML must be present in package

Extension appears to use GSettings but no `.gschema.xml` file is included in the package.

GSettings Schemas

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

talesam posted a review
EGO-P-003: the only GSettings use is reading org.gnome.desktop.lockdown (extension.js) to honour disable-save-to-disk — the same system schema gnome-shell's own screenshot.js reads. The extension defines no settings of its own, so there is no .gschema.xml to ship. EGO-A-005: clipboard access is the feature itself. The user presses a button to copy the screenshot (PNG) or the OCR result (text) to the clipboard. Nothing is ever read from the clipboard, nothing is sent anywhere, and no default keyboard shortcut touches clipboard data. This is now stated in the description, as the guidelines require. External binaries: gst-inspect-1.0 and lspci are probed read-only to pick a working encoder; ffmpeg concatenates pause/resume segments; tesseract powers the optional OCR. All are optional, spawned via Gio.Subprocess with no shell, cancelled on disable(), and none is privileged.