Review of "Gnofi" version 1.0.0 (3)

Details Page Preview

An extensible launcher, picker, search and command palette

Extension Homepage
https://github.com/aylur/gnome-extensions

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3 manual_review 1

Shexli found 4 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • src/extension/GnofiWindow/View/PickerView/SearchPickerView.js:24
    St.Clipboard.get_default()

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 8 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • vendor/gnim/dbus/service.js:142
    console.error(err)
  • vendor/gnim/dbus/service.js:179
    console.error(err)
  • vendor/gnim/dbus/service.js:207
    console.error(err)
  • vendor/gnim/dbus/service.js:127
    console.warn(Error(`cannot find property info "${propertyName}"`))
  • vendor/gnim/dbus/service.js:133
    console.warn(Error(`cannot set property "${propertyName}": not writable`))
  • vendor/gnim/dbus/service.js:167
    console.warn(Error(`cannot find property info "${propertyName}"`))
  • vendor/gnim/dbus/service.js:189
    console.warn(Error(`cannot find property info "${propertyName}"`))
  • vendor/gnim/dbus/service.js:195
            console.warn(
              Error(
                `cannot set property "${propertyName}": invalid variant ${value.get_type_string()}, expected ${prop.signature}`,
              ),
            )

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 9 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • vendor/gnim/jsx/reactive.js:19
    console.error(err)
  • vendor/gnim/jsx/reactive.js:54
    console.error(err)
  • vendor/gnim/jsx/reactive.js:83
    console.error(err)
  • vendor/gnim/jsx/reactive.js:199
    console.error(Error("out of tracking context: will not be able to clean up"))
  • vendor/gnim/jsx/reactive.js:423
    console.error(err)
  • vendor/gnim/jsx/reactive.js:492
    console.error(err)
  • vendor/gnim/jsx/reactive.js:579
    console.error(err)
  • vendor/gnim/jsx/reactive.js:274
    console.warn("Accessor implicitly converted to a primitive value.")
  • vendor/gnim/jsx/reactive.js:533
    console.warn(Error("effects created outside a `createRoot` will never be disposed"))

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • src/extension/GnofiWindow/View/Context/AppPicker.js:72
    this.appSystem = Shell.AppSystem.get_default()

All Versions

Version Status
1.0.0 (3) Unreviewed
2 Rejected
1 Rejected