Review of "Global Menu for GNOME" version 19

Details Page Preview

Brings a macOS-style global menu bar to GNOME. Adds contextual File, Edit, View, Go, Window, and Help menus for the focused app, plus a configurable System Menu with quick access to Settings, Terminal, Software Center, Force Quit, and power options. Create your own custom menus with shell commands or keyboard shortcuts, and personalize the System Menu icon from bundled distro logos, an Apple-style icon, or your own image.

Extension Homepage
https://github.com/ShiroOSL/global-menu-for-gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 3 warning 2 manual_review 1

Shexli found 6 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • clipboardHistory.js:40
    St.Clipboard.get_default()
  • clipboardHistory.js:127
    St.Clipboard.get_default()
  • emojiPicker.js:2117
    St.Clipboard.get_default()

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • systemInfoPanel.js:46
    GLib.file_get_contents(path)

EGO-I-002 error

Gtk, Gdk and Adw must not be imported in shell process files

GTK library `Adw` must not be imported in extension process files.

Do not import GTK libraries in GNOME Shell

  • systemInfoPanel.js:10
    import Adw from 'gi://Adw?version=1';

EGO-I-002 error

Gtk, Gdk and Adw must not be imported in shell process files

GTK library `Gdk` must not be imported in extension process files.

Do not import GTK libraries in GNOME Shell

  • systemInfoPanel.js:11
    import Gdk from 'gi://Gdk?version=4.0';

EGO-I-002 error

Gtk, Gdk and Adw must not be imported in shell process files

GTK library `Gtk` must not be imported in extension process files.

Do not import GTK libraries in GNOME Shell

  • systemInfoPanel.js:14
    import Gtk from 'gi://Gtk?version=4.0';

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • systemInfoPanel.js:256
    new Adw.Application({
      application_id: 'io.github.ShiroOSL.GlobalMenu.SystemInfo',
    })
  • systemInfoPanel.js:261
    application.connect('activate', () => {
      if (!window) {
        window = buildWindow(application);
      }
      window.present();
    })

All Versions

Version Status
20 Unreviewed
19 Rejected
18 Rejected
17 Rejected
16 Rejected
15 Active
14 Active
13 Rejected
12 Active
11 Rejected
10 Rejected
9 Active
8 Rejected
7 Active
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Shiro auto- rejected
Auto-rejected because of new version 20 was uploaded