Review of "Pomodoro Sky" version 1.0.0 (2)

Details Page Preview

A beautiful sky-blue, glassmorphism Pomodoro timer that lives in your top bar. Tracks work/break sessions with a glass progress bar, session dots, gentle sound + notifications, and a built-in settings page — no separate Settings app needed.

Extension Homepage
https://github.com/rezabibak/Pomodoro-Gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:179
    this._toggleButton.connect('clicked', () => this._onToggleClicked())
  • extension.js:333
    entry.clutter_text.connect('activate', commit)
  • extension.js:319
            entry.clutter_text.connect('insert-text', (clutterText, text) => {
                if (!/^\d*$/.test(text))
                    GObject.signal_stop_emission_by_name(clutterText, 'insert-text');
            })
  • extension.js:334
    entry.clutter_text.connect('key-focus-out', commit)
  • extension.js:73
            this.menu.connect('open-state-changed', (menu, open) => {
                if (!open)
                    this._showTimerView();
            })

All Versions

Version Status
1.0.0 (2) Unreviewed
1.0.0 (1) Rejected