Review "Selected Force Quit" version 1

Review of "Selected Force Quit" version 1

Details Page Preview

Selected Force Quit

Opens a Force Quit Applications dialog when RAM hits 95% or CPU stays at 95% for five seconds, so you can choose which app or window to close instead of losing the one you are working in. Click the panel icon to open the dialog immediately. Apps with more than one window can be expanded so you can close a single window without quitting the whole application. An optional helper in the source repository can lock a small RAM reserve so the dialog still appears when the machine is nearly out of memory.

Extension Homepage: https://github.com/itsvishwasmalik/ubuntu-lifesaver

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

apps.js:63

GLib.file_get_contents(`/proc/${pid}/statm`)

monitor.js:5
```
GLib.file_get_contents(path)
```
oom.js:30
```
GLib.file_get_contents(path)
```

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

extension.js:200

        this._indicator.connect('button-press-event', (_actor, event) => {
            if (event.get_button() === 1) {
                this._showDialog('ram');
                return Clutter.EVENT_STOP;
            }
            return Clutter.EVENT_PROPAGATE;
        })

All Versions

Version	Status
1	Unreviewed