Review of "Real Calendar" version 1

Details Page Preview

13-month calendar (with Sol) and a 13-sign zodiac including Ophiuchus. Adds a second calendar in the GNOME date menu, or replaces the default one. 24-hour clock and 7-day week stay unchanged.

Extension Homepage
https://github.com/Boobuh/real-calendar

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:23
            this._gregorianBtn = new St.Button({
                style_class: 'real-calendar-mode-button',
                can_focus: true,
                label: 'Gregorian',
                x_expand: true,
            })
  • extension.js:29
            this._realBtn = new St.Button({
                style_class: 'real-calendar-mode-button',
                can_focus: true,
                label: 'Real',
                x_expand: true,
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:35
    this._gregorianBtn.connect('clicked', () => this._setView('gregorian'))
  • extension.js:36
    this._realBtn.connect('clicked', () => this._setView('real'))

All Versions

Version Status
1 Unreviewed