Review of "TopRates" version 1.0.1 (1)

Details Page Preview

Live stock, ETF, index, currency and crypto quotes from Yahoo Finance in the GNOME top bar, with a popup listing every symbol you follow and its price history.

Extension Homepage
https://github.com/dimitrmo/toprates

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:801
    this._cacheFile().load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:470
            this.menu.connect('open-state-changed', (_menu, isOpen) => {
                if (isOpen && this._isStale())
                    this._refresh();
                if (isOpen)
                    this._startAgeTicker();
                else
                    this._stopAgeTicker();
            })

EGO-M-005 warning

metadata session-modes must be omitted when only user mode is declared

Field `session-modes` should be omitted when it only contains `user`.

metadata.json must be well-formed

  • metadata.json
    session-modes=['user']

All Versions

Version Status
1.0.6 (8) Unreviewed
1.0.5 (7) Rejected
1.0.4 (6) Rejected
1.0.3 (5) Unreviewed
1.0.3 (4) Unreviewed
1.0.2 (3) Rejected
1.0.2 (2) Rejected
1.0.1 (1) Rejected

Previous Reviews on this Version

pascal0765 auto- rejected
Auto-rejected because of new version 1.0.2 (2) was uploaded