Review of "Eisenhower Matrix" version 1

Details Page Preview

A desktop Eisenhower matrix for sorting tasks by urgency and importance.

Extension Homepage
https://github.com/laxitajain

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:325
    file.load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:517
            this._menu.connect('open-state-changed', (_menu, open) => {
                if (!open)
                    this._destroyMenu();
            })
  • extension.js:237
            entry.clutter_text.connect('activate', () => {
                const text = entry.get_text().trim();
                if (text)
                    this._addTask(info.key, text);
                entry.set_text('');
                this._toggleAdd(info.key, false);
            })
  • extension.js:244
            entry.clutter_text.connect('key-press-event', (_actor, event) => {
                if (event.get_key_symbol() === Clutter.KEY_Escape) {
                    entry.set_text('');
                    this._toggleAdd(info.key, false);
                    return Clutter.EVENT_STOP;
                }
                retur

All Versions

Version Status
1 Unreviewed