Review of "MacOS-style Launchpad" version 1

Details Page Preview

Gnome shell extension to add Mac OS-like launchpad, that works with touchpad!

Extension Homepage
https://github.com/example/macos-launchpad

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 20 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:40
    console.error(`${LOG_PREFIX} FAILED to register keybinding: ${e}\n${e.stack}`)
  • extension.js:57
    console.error(`${LOG_PREFIX} error removing keybinding: ${e}`)
  • extension.js:74
    console.error(`${LOG_PREFIX} FAILED to create LaunchpadView: ${e}\n${e.stack}`)
  • extension.js:90
    console.error(`${LOG_PREFIX} FAILED in _toggle(): ${e}\n${e.stack}`)
  • extension.js:100
                    console.error(`${LOG_PREFIX} event.get_gesture_phase is not available ` +
                        'on this GNOME/Clutter version — pinch detection cannot work here.')
  • extension.js:160
    console.error(`${LOG_PREFIX} FAILED in _onCapturedEvent(): ${e}\n${e.stack}`)
  • extension.js:14
    console.log(`${LOG_PREFIX} enable() called`)
  • extension.js:33
    console.log(`${LOG_PREFIX} keybinding triggered`)
  • extension.js:37
                console.log(`${LOG_PREFIX} keybinding registered: ` +
                    this._settings.get_strv('toggle-keybinding'))
  • extension.js:43
    console.log(`${LOG_PREFIX} enable() finished`)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 9 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • launchpadView.js:298
                    console.error(`${LOG_PREFIX} FAILED to launch app ` +
                        `${appInfo.get_id()}: ${e}\n${e.stack}`)
  • launchpadView.js:393
    console.error(`${LOG_PREFIX} FAILED inside close(): ${e}\n${e.stack}`)
  • launchpadView.js:80
    console.log(`${LOG_PREFIX} Overview is showing — force-closing Launchpad`)
  • launchpadView.js:153
    console.log(`${LOG_PREFIX} CLOSE PATH: Escape (key-press-event on panel)`)
  • launchpadView.js:219
    console.log(`${LOG_PREFIX} found ${apps.length} apps, ${columns} columns`)
  • launchpadView.js:280
                    console.log(`${LOG_PREFIX} CLOSE PATH: app icon clicked ` +
                        `(${appInfo.get_display_name()})`)
  • launchpadView.js:306
    console.log(`${LOG_PREFIX} view.open()`)
  • launchpadView.js:315
    console.log(`${LOG_PREFIX} addTopChrome — chrome registered`)
  • launchpadView.js:321
    console.log(`${LOG_PREFIX} Main.overview was visible — hiding it`)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
1 Unreviewed