Review of "ntfy for GNOME" version 0.3.0 (1)

Details Page Preview

Receive ntfy notifications in GNOME Shell from ntfy.sh or your own server. Subscribe to public and private topics, store access tokens in the desktop keyring, and read the last 20 received messages in the panel menu. Includes a panel message-count badge, connection status, automatic reconnection, and a desktop notification switch. Requires libsecret and a desktop keyring for access tokens. Recent history is kept in memory and clears when the extension stops, including screen locking and logout.

Extension Homepage
https://github.com/shukiv/ntfy.gnome

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:31
            this._icon = new St.Icon({
                icon_name: 'preferences-system-notifications-symbolic',
                style_class: 'system-status-icon',
            })
  • extension.js:40
            this._notificationToggle = new PopupMenu.PopupSwitchMenuItem(
                _('Desktop notifications'), this._settings.get_boolean('notifications-enabled'))
  • extension.js:50
    this._recentMenu = new PopupMenu.PopupSubMenuMenuItem(_('Recent messages'))
  • extension.js:47
    this._subscriptionsSection = new PopupMenu.PopupMenuSection()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:206
                source.connect('destroy', () => {
                    if (this._source === source)
                        this._source = null;
                })

All Versions

Version Status
0.3.1 (2) Unreviewed
0.3.0 (1) Rejected

Previous Reviews on this Version

shukivaknin auto- rejected
Auto-rejected because of new version 0.3.1 (2) was uploaded