Review of "SimpleWeather" version 51.0.1 (11)

Details Page Preview

A highly customizable weather extension for GNOME Shell. Features: - Hourly and weekly forecasts - Multiple locations and current location - Customizable units, weather data, and layout - Multiple weather providers - No GNOME Weather required

Extension Homepage
https://github.com/romanlefler/SimpleWeather

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • welcome.js:93
    this.#abort = abort
  • welcome.js:94
    this.#okay = okay
  • welcome.js:161
    this.#okay = okay

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:89
    this.#gsettings = this.getSettings()
  • extension.js:175
            this.#sunTimeIcon = new St.Icon({
                icon_name: "daytime-sunset-symbolic",
                style_class: "system-status-icon"
            })
  • extension.js:169
            this.#sunTimeLabel = new St.Label({
                text: "...",
                y_align: Clutter.ActorAlign.CENTER,
                y_expand: true,
                style: "padding-left: 8px;"
            })
  • welcome.js:93
    this.#abort = abort
  • welcome.js:94
    this.#okay = okay
  • welcome.js:161
    this.#okay = okay

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:193
            indic.menu.connect("open-state-changed", (_, isOpen) => {
                if (isOpen)
                    actor.add_style_class_name("swa-open");
                else
                    actor.remove_style_class_name("swa-open");
            })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['46', '48', '49', '50', '51']

All Versions

Version Status
51.0.1 (11) Active
51.0.0 (10) Active
50.1.1 (9) Active
50.1.0 (8) Rejected
50.0.0 (7) Active
49.2.0 (6) Active
49.1.0 (5) Active
49.0.0 (4) Active
48.2.0 (3) Active
48.1.0 (2) Active
48.0.0 (1) Active

Previous Reviews on this Version

JustPerfection active