Review "Always On Indicate" version 1.0.0 (1)

Review of "Always On Indicate" version 1.0.0 (1)

Details Page Preview

Always On Indicate

See and manage windows that are always on top or always on the visible workspace. Marks them with a window outline, a corner badge, a top bar indicator and a dock badge, adds configurable shortcuts (and finds the ones you already have), auto-pins apps by rule, and adapts to server-side, client-side and custom window decorations.

Extension Homepage: https://github.com/BeekrBonkr/AlwaysOnIndicate

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

overlays.js:205

this._badge = new Badge(manager, window)

overlays.js:201

        this._outline = new St.Widget({
            style_class: 'aoi-outline',
            reactive: false,
        })

overlays.js:398
```
ring
```

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

overlays.js:238

this._badge.connect('style-changed', () => this._queueSync())

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

prefs.js:1031

this._rulesGroup = new RulesGroup(settings, window)

All Versions

Version	Status
1.0.0 (1)	Unreviewed