Review of "System Monitor Pro" version 1

Details Page Preview

Beautiful top bar system monitor: CPU (per-core usage, freq, temp), RAM (breakdown, DIMM temperatures, top processes), GPU, disks and network. Hover a chip to open its detail panel.

Extension Homepage
https://github.com/nativeanish/system-monitor-pro-anish

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:40
    GLib.file_get_contents(path)

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:345
    this._appTracker = Shell.WindowTracker.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:1001
            this.menu.connect('open-state-changed', (_m, open) => {
                if (open) {
                    this._applyGlass();
                    this._store.refresh();
                    if (this._key === 'net')
                        this._store.refreshNetProcs();
                    this.updatePanel();
             

All Versions

Version Status
1 Unreviewed