Review of "CORE STATS" version 9

Details Page Preview

Display hardware temperatures (CPU, GPU, NVMe, etc.)

Extension Homepage
https://github.com/devilbd/gnome-extensions/tree/main/core-stats

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:452
    console.warn('CoreStats: Could not set z-order:', e)
  • extension.js:73
    console.error('CoreStats init error:', e)
  • extension.js:98
    console.error('CoreStats update stats error:', e)
  • extension.js:266
    console.error('CoreStats: Error initializing drives:', e)
  • extension.js:507
    console.error('CoreStats: Error updating stats:', e)
  • extension.js:651
    console.error(`CoreStats: Error reading usage for ${item.mountPoint}:`, e)
  • extension.js:762
    console.error(`CoreStats: Failed to read file ${path}:`, e)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:329
            this._scrollView = new St.ScrollView({
                style_class: 'core-stats-scrollview',
                hscrollbar_policy: isVertical ? St.PolicyType.NEVER : (width > 0 ? St.PolicyType.AUTOMATIC : St.PolicyType.NEVER),
                vscrollbar_policy: isVertical ? (height > 0 ? St.PolicyType.AUTO

All Versions

Version Status
12 Unreviewed
11 Rejected
10 Rejected
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

devilbd auto- rejected
Auto-rejected because of new version 10 was uploaded