Review of "MusicAMP Player" version 3

Details Page Preview

Music player with playlist support.

Extension Homepage
https://github.com/mdoksa76/musicamp

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:956
            GLib.timeout_add(GLib.PRIORITY_DEFAULT, 50, () => {
                if (this._controlBox && this._tabsScroll) {
                    // Širina reda kontrola je konstanta (fiksni gumbi). Izmjeri je
                    // JEDNOM i zaključaj - inače premjeravanje pri brisanju tabova
                    // hvata

All Versions

Version Status
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
didn't review since seems like AI generated: https://gjs.guide/extensions/review-guidelines/best-practices.html#ui-elements-icons-vs-emojis