Review of "Copy Now Playing" version 1

Details Page Preview

Adds a Copy button next to the Prev/Play/Next controls on GNOME's media player notification, letting you copy the currently playing track's artist and title to the clipboard. Also offers a keyboard shortcut, a configurable text format, and an optional Copy Link button. Works with any MPRIS-compatible player ( eg: Spotify on browsers and more)

Extension Homepage
https://github.com/Nyndow/copy-now-playing

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:61
    St.Clipboard.get_default()

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:67
                this._copyResetId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, RESET_DELAY_MS, () => {
                    icon.icon_name = COPY_ICON;
                    this._copyResetId = 0;
                    return GLib.SOURCE_REMOVE;
                })

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection active
If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions