Review of "Corner Player for Spotify" version 1

Details Page Preview

Reveal a compact Spotify player from either lower screen edge. Unofficial and not affiliated with Spotify.

Extension Homepage
https://github.com/Bernardik226/spotify-corner-player-gnome

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:303
                this._artActor = new St.Icon({
                    icon_name: 'audio-x-generic-symbolic',
                    icon_size: 32,
                    x_align: Clutter.ActorAlign.CENTER,
                    y_align: Clutter.ActorAlign.CENTER,
                })
  • extension.js:171
            this._artBin = new St.Button({
                style_class: 'message-icon spotify-corner-art',
                width: 64,
                height: 64,
                clip_to_allocation: true,
                reactive: true,
                can_focus: true,
                track_hover: true,
                accessible_name:
  • extension.js:197
            this._artist = new St.Label({
                style_class: 'spotify-corner-artist',
                text: 'Spotify',
                x_expand: true,
            })
  • extension.js:146
    this._exitItem = new PopupMenu.PopupMenuItem(_('Exit'))
  • extension.js:135
    this._leftSideItem = new PopupMenu.PopupMenuItem(_('Left'))
  • extension.js:139
    this._rightSideItem = new PopupMenu.PopupMenuItem(_('Right'))
  • extension.js:124
            this._switchItem = new PopupMenu.PopupSwitchMenuItem(
                _('Widget enabled'), this._settings.get_boolean('enabled'))
  • extension.js:192
            this._title = new St.Label({
                style_class: 'spotify-corner-title',
                text: _('Nothing playing'),
                x_expand: true,
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:182
    this._artBin.connect('clicked', () => this._mpris.raise())
  • extension.js:136
            this._leftSideItem.connect('activate', () =>
                this._settings.set_string('side', 'left'))
  • extension.js:383
    this._pressureBarrier.connect('trigger', () => this._show())
  • extension.js:140
            this._rightSideItem.connect('activate', () =>
                this._settings.set_string('side', 'right'))

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:458
            this._pointerTimer = GLib.timeout_add(
                GLib.PRIORITY_DEFAULT, 100, () => {
                    if (!this._shown) {
                        this._pointerTimer = 0;
                        return GLib.SOURCE_REMOVE;
                    }
    
                    const [x, y] = global.get_pointer();
          

All Versions

Version Status
1 Unreviewed