Review of "Focus Timer" version 4

Details Page Preview

A Pomodoro timer for GNOME with top-bar controls, notifications showing remaining time, gentle break overlay, and a lock screen widget. Companion extension for the Focus Timer app. More about Focus Timer: https://focustimerhq.github.io

Extension Homepage
https://github.com/focustimerhq/gnome-shell-extension-focus-timer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1

Shexli found 1 issue that may need reviewer attention.

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['48', '49', '50', '51']

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You shouldn't hold different timeout ids in the same property (line 917 and 919 `indicator.js`). 2. Where do you use the name (line 917, 920 `indicator.js`)? You are doing that in other files too. 3. Timeout should be removed before creating a new one (line 410 `screenOverlay.js`). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
kamilprusko posted a review
Thank you for the review! 1. `GLib.timeout_add_seconds` and `GLib.timeout_add` no longer share the same `this._timeoutId` property. 2. The source names (uses of `GLib.Source.set_name_by_id`) weren't used anywhere - I removed them. I thought it's better to have them "just in case" for debugging... 3. Added explicit `GLib.source_remove(this._intervalId)`. Creating possibly duplicated timeouts were already guarded by `this._began`.