Review of "files-launcher" version 12

Details Page Preview

files-launcher is a menu that allows you to launch arbitary files options are view, edit or run (if it is an executable), you can also put directories in it and then the options will be list, open in the default File Browser, or in the default shell 🤠.

Extension Homepage
https://github.com/grizzlysmit/files-launcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:759
    filesfile.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • prefs.js:331
    console.error('files-launcher::Error selecting custom icon:', error.message)
  • prefs.js:1192
    console.error('files-launcher::Error selecting file:', error.message)
  • prefs.js:1249
    console.error('files-launcher::Error selecting directory:', e.message)
  • prefs.js:1254
    console.error('files-launcher::Error selecting directory:', error.message)
  • prefs.js:1327
    console.error('files-launcher::Error selecting file:', error.message)
  • prefs.js:1381
    console.error('files-launcher::Error selecting directory:', e.message)
  • prefs.js:1386
    console.error('files-launcher::Error selecting directory:', error.message)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:599
            this.settingsID_icon_size = this.settings.connect('changed::menu-button-icon-size', () => {
                this._indicator.refesh_menu();
            })
  • extension.js:602
            this.settingsID_show_logs = this.settings.connect('changed::show-logs', () => {
                LogMessage.set_show_logs(this.settings.get_boolean('show-logs'));
            })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['48', '49', '50', '51']

All Versions

Version Status
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active