Review "Re: Notification Center" version 1.0.0 (1)

Review of "Re: Notification Center" version 1.0.0 (1)

Details Page Preview

Re: Notification Center

by MGueL

Separate the notification center from the calendar into an independent panel with customizable appearance, behavior, and notification management. A continuation of the original Notification Center project by Selenium-H.

Extension Homepage: https://github.com/MGueL-CR/re-notification-center

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-I-001 error

deprecated modules must not be imported

Deprecated module `Lang` is imported.

Do not use deprecated modules

extension.js:10

LangClass           = imports.lang.Class

extension.js:10
```
imports.lang.Class
```
prefsGtk3.js:14
```
Lang           = imports.lang
```
prefsGtk3.js:14
```
imports.lang
```
prefsGtk4.js:16
```
Lang           = imports.lang
```
prefsGtk4.js:16
```
imports.lang
```

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

extension.js:41

notificationCenter.reloadProfilesSignal = notificationCenter.prefs.connect("changed::reload-profiles-signal", () => notificationCenter.loadPreferences())

All Versions

Version	Status
1.0.0 (1)	Unreviewed