Review "Charge Boost" version 1.0.1 (1)

Review of "Charge Boost" version 1.0.1 (1)

Details Page Preview

Charge Boost

Temporarily bypass UPower's existing battery charge thresholds to charge to full once. Restores them when full, unplugged, cancelled, or disabled.

Extension Homepage: https://github.com/RiRa12621/chargeboost

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

extension.js:90
```
client.run_dispose()
```
extension.js:132
```
device.run_dispose()
```
extension.js:149
```
entry.device.run_dispose()
```
extension.js:273
```
this._client?.run_dispose()
```

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

stylesheet.css
```
placeholder stylesheet.css
```

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

extension.js:74

        this._toggle.connect('clicked', () => {
            this._error = null;
            if (this._boosted.size > 0)
                this._restoreAll();
            else
                this._start();
            this._sync();
        })

All Versions

Version	Status
1.0.1 (1)	Unreviewed