Review of "gScreenProfiles" version 1.0.0 (1)

Details Page Preview

Save, restore and manage display profiles from the top bar.

Extension Homepage
https://github.com/KleinerKobold/gscreenprofiles

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:101
            this._confirmationSwitch = new PopupMenu.PopupSwitchMenuItem(
                _('Confirm changes'), this._settings.get_boolean('confirm-changes'))

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:154
    entry.clutter_text.connect('activate', submit)
  • extension.js:114
    dialog.connect('destroy', () => this._dialogs?.delete(dialog))

All Versions

Version Status
1.0.2 (3) Unreviewed
1.0.1 (2) Rejected
1.0.0 (1) Rejected

Previous Reviews on this Version

kleinerKobold auto- rejected
Auto-rejected because of new version 1.0.1 (2) was uploaded