Review of "Agent Usage Indicator" version 6

Details Page Preview

Codex, Claude and Antigravity quotas via CLI logins.

Extension Homepage
https://gitlab.com/bruno.englert/gnome-extension-codex-limit-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
9 Unreviewed
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Active
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Still seems you aren't cleanup any of those timeouts in `providers/codex/appServer.js` on disable/destroy.
brunoenglert posted a review
Hey, I think there's a misunderstanding. There is cleanup: In `providers/codex/appServer.js`, `destroy()` starts at line 256. The two paths are: - Request timeouts: `destroy()` → `_rejectPending()` → `_rejectRequest()` → `_takePending()`. The actual `GLib.Source.remove(entry.timeoutId)` is at line 434. - Stderr-drain timeout: `destroy()` → `_failConnection()` → `finishStderrDrain()`. That callback removes `connection.stderrDrainId` at line 574. Having said that, there are way too many indirections, so I think I'll refactor this in the future version to make it much simpler.
JustPerfection posted a review
It should be clear for the reviewers that the timeouts getting removed on destroy and before creating a new one. Trace back 4 steps to find the timeout removal isn't really a good approach. When one of them get removed in the future update, you can break the chain and we can miss it in the diff.