Review of "Unblank lock screen" version 36

Details Page Preview

Unblank lock screen.

Extension Homepage
https://github.com/sunwxg/gnome-shell-extension-unblank

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 3

Shexli found 5 issues that may need reviewer attention.

EGO-I-002 error

Gtk, Gdk and Adw must not be imported in shell process files

GTK library `Gdk` must not be imported in extension process files.

Do not import GTK libraries in GNOME Shell

  • extension.js:6
    import Gdk from 'gi://Gdk';

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:66
                                                        this.powerProxy.connect('g-properties-changed',
                                                                                this._onPowerChanged.bind(this))

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['51']

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:71
        getPreferencesWidget() {
            return buildPrefsWidget(this.getSettings());
        }

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please fix those warnings mentioned by shexli. 2. You cannot import `Gdk` to the GNOME Shell process (line 6 `extension.js`): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell)