Review of "panel scroll" version 31

Details Page Preview

Switch windows or workspace by mouse scroll on the panel. Pointer on left of panel, switch windows. Pointer on right of panel, switch workspaces.

Extension Homepage
https://github.com/sunwxg/gnome-shell-extension-panelScroll

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 3

Shexli found 5 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.unblank.gschema.xml
    id='org.gnome.shell.extensions.panelScroll' path='/org/gnome/shell/extensions/panelScroll/'

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:45
    		this.debounceID = this.settings.connect("changed::" + KEY_DEBOUNCE, () => {
    			this.debounce = this.settings.get_int(KEY_DEBOUNCE);
    		})

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['51']

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:87
        getPreferencesWidget() {
            return buildPrefsWidget(this.getSettings());
        }

All Versions

Previous Reviews on this Version

JustPerfection rejected
Please fix those warnings mentioned by shexli.