GNOME Shell Extensions

Review of "Floating Dock" version 41

Details Page Preview

Floating Dock

by sun_wang

Move dock anywhere on the desktop Press Ctrl+Alt+k to vi mode Press lowercase alphabet, open new window or active the window Press uppercase alphabet, force to open new window Point on the main button, change workspace by mouse scroll Right click the main button, show some selections

Extension Homepage
https://github.com/sunwxg/gnome-shell-extension-floatingDock
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 4

Shexli found 5 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • aroundButton.js:36 
    actions = new Actions({})
  • aroundButton.js:36 
    new Actions({})

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • itemContainer.js:175 
                this._menu.connect('activate-window', (menu, window) => {
                this.activateWindow(window); })
  • itemContainer.js:177 
                this._menu.connect('open-state-changed', (menu, isPoppedUp) => {
                if (!isPoppedUp)
                    this.emit('activate-window');
            })
  • windowPreview.js:138 
            this._mutterWindowId = this._mutterWindow.connect('destroy', () => {
            this.destroy();
            this._mutterWindowId = 0;
        })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json 
    shell-version=['51']

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:383 
        getPreferencesWidget() {
        let frame = new Frame(this.getSettings(), this.dir);
        return frame.widget;
    }

All Versions

Previous Reviews on this Version

JustPerfection active